Repository navigation
fix(web): custom-sorted inbox groups keep their place when their top thread goes - #1028
Merged
Merged
Conversation
…thread goes In Custom sort with the inbox grouped by project or computer, a group the user never dragged sat wherever its first thread fell in the custom order, so wrapping, archiving or pinning that thread could make another group jump ahead of it (#1015). Custom sort now remembers where it first showed each group, in a new device setting (inboxCustomGroupOrder) kept apart from the dragged order, so the other sorts still move undragged groups with their first row. A group new to the list goes last. Dragged groups still win. "Use automatic order" (now offered when Custom sort remembers places) and "Reset custom order" clear the remembered places so groups take them afresh. Closes #1015
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1015.
In Custom sort with the inbox grouped by project or computer, a group you never dragged sat wherever its first thread fell in the custom order. Wrapping, archiving or pinning that thread could make another group jump ahead of it.
Custom sort now remembers where it first showed each group, in a new per-device setting (
inboxCustomGroupOrder). It's kept apart from the dragged group order, so Recent and the other sorts still move undragged groups with their first row. A group new to the list goes last, and dragged groups still win. "Use automatic order" on a group header (now offered when Custom sort remembers places) and "Reset custom order" clear the remembered places, so groups take them afresh from the current list.The submitter's patch saved discovered groups into the dragged order, which would have frozen groups in every sort, and also saved every new thread into the custom order, which the existing "unplaced threads go last" rule already covers. This takes the group half only.
Known limits: on the first run, a computer that loads after the active one has its groups placed last once. Two windows discovering different new groups at the same moment can lose one group's remembered place (the dragged order has the same race).
Checked: fmt, lint, typecheck, Sidebar logic tests (new regression test), web and desktop settings tests, full web browser suite.